-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added thumbnail to MagickImage #183
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
Copyright Dirk Lemstra https://github.com/dlemstra/magick-wasm. | ||
Licensed under the Apache License, Version 2.0. | ||
*/ | ||
|
||
import { MagickGeometry } from '@src/types/magick-geometry'; | ||
import { TestImages } from '@test/test-images'; | ||
|
||
describe('MagickImage#thumbnail', () => { | ||
it('should resize the image to within the given dimensions', () => { | ||
TestImages.Builtin.logo.use(image => { | ||
image.thumbnail(100, 100); | ||
|
||
expect(image.width).toBe(100); | ||
expect(image.height).toBe(75); | ||
}); | ||
}); | ||
|
||
it('should resize the image based on the given width', () => { | ||
TestImages.Builtin.logo.use(image => { | ||
image.thumbnail(150, 0); | ||
|
||
expect(image.width).toBe(150); | ||
expect(image.height).toBe(113); | ||
}); | ||
}); | ||
|
||
it('should resize the image based on the given height', () => { | ||
TestImages.Builtin.logo.use(image => { | ||
image.thumbnail(0, 100); | ||
|
||
expect(image.width).toBe(133); | ||
expect(image.height).toBe(100); | ||
}); | ||
}); | ||
|
||
it('should resize based on the given geometry', () => { | ||
TestImages.Builtin.logo.use(image => { | ||
image.thumbnail(new MagickGeometry(200, 200)); | ||
|
||
expect(image.width).toBe(200); | ||
expect(image.height).toBe(150); | ||
}); | ||
}); | ||
|
||
it('should remove all image profiles except the icc/icm profile', () => { | ||
TestImages.fujiFilmFinePixS1ProJpg.use(image => { | ||
expect(image.profileNames.length).toBe(5); | ||
|
||
image.thumbnail(100, 100); | ||
|
||
expect(image.profileNames.length).toBe(1); | ||
expect(image.profileNames[0]).toBe('icc'); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need an extra test that makes sure that the some of the metadata is not available in the resulting image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test for that! FYI Magick.NET is also missing this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems EXIF attributes (so
.getAttribute
, not.getProfile
) are not removed, also not by.strip()
. Is this intended behaviour?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try not to look at the Magick.NET tests and just add here what I think that should be added. Those attributes are not removed because they will not be stored to file. Maybe to make sure this is working correctly we could save the thumbnail to a blob and then read it again but I don't know if we really need to do that.