-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fractional rating doesn't work for small images (11x11) #9
Comments
Thanks, I'll look into it as soon as I get around |
I could reproduce this if [[DLStarRatingControl alloc] initWithFrame:CGRectMake(0, 154, 320, 153) andStars:5 isFractional:NO]; I'll investigate further, but the code was provided by @kuchmiyalex and I need to dig into it first. |
@kuchmiyalex I could use your support on this. The method |
You should use image with width fractional by 10, so it could be 10x10/20x20/30x30px image. |
Thanks for the feedback, I'll add it to the docs. with kind regards, David Linsin // web: http://dlinsin.github.com On 11.03.2012, at 13:44, kuchmiyalexreply@reply.github.com wrote:
|
Great. Thanks Alex. I goess it would also work well with images in increments of 5 if you set kNumberOfFractions to 5. |
* master: updated podspec Basic spec file, the version and tag/commit for the build will need to be updated. no not retain delegate Added description for fractional images #9 adopted description dropping ios3 support minor cleanup of #7 Unused method removed Fractional rating support added zucchini reference Added UI testing with zucchini Added accessibility labels for individual stars moved link to main repo Revert "moved sample screenshot to Downloads area" moved sample screenshot to Downloads area added ability to set custom images for single stars and updated the demo project with this setting added ability to set custom images for single stars and updated the demo project with this setting updated for xcode 4 Conflicts: DLStarRating/DLStarRatingControl.h DLStarRating/DLStarRatingControl.m DLStarRatingDemo/Classes/DLStarRatingDemoViewController.m DLStarRatingDemo/DLStarRatingDemo.xcodeproj/project.pbxproj
There seems to be a problem when using small images. 11x11 px in my case. Not sure why.
Here's how it looks like rendered with DLStarRatingControl -- http://a.yfrog.com/img812/9646/l37.png
Here's the 11x11 star -- http://a.yfrog.com/img576/7623/qr8d.png
The text was updated successfully, but these errors were encountered: