Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-sass 5.0.0 #781

Closed
wants to merge 1 commit into from
Closed

Update node-sass 5.0.0 #781

wants to merge 1 commit into from

Conversation

tanrax
Copy link

@tanrax tanrax commented Nov 10, 2020

No description provided.

@rekmarks
Copy link

It would be positively astounding if this were merged 🙏

@rekmarks
Copy link

It'll probably require a major version bump of gulp-sass due to changes to permitted Node version, but it doesn't look like it'll require any code changes: https://github.com/sass/node-sass/releases/tag/v5.0.0

@tanrax
Copy link
Author

tanrax commented Nov 25, 2020

Only with this small change it works for me

@sujeetkrjaiswal
Copy link

Why should gulp-sass needs a dependency on node-sass, given users can choose between node-sass and sass (dart-sass) as a compiler? An issue also has been opened for this: #782

@C-Lodder
Copy link

Just make it a peerDependency so people have to manually install and manage the node-sass version.
Depending on a package that needs to ship new binaries for every Node.js version is a PITA

@rekmarks
Copy link

Signal boost: The problem hasn't gone away; I'd still love for this to happen.

@xzyfer
Copy link
Collaborator

xzyfer commented Jun 15, 2021

Thanks all, close this to focus efforts on #802 which is more rounded at this point in time.

@xzyfer xzyfer closed this Jun 15, 2021
@tanrax tanrax deleted the patch-1 branch June 15, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants