Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-sass to v6.0.0 #795

Closed
wants to merge 2 commits into from
Closed

Bump node-sass to v6.0.0 #795

wants to merge 2 commits into from

Conversation

sstrubberg
Copy link

To support Node v16

To support Node v16
package.json Outdated Show resolved Hide resolved
Co-authored-by: Michael Mifsud <xzyfer@gmail.com>
@cyrilverloop
Copy link

Hi,

Node 16 support would be appreciated.
Is there any help needed here ?

@CasualEngineerZombie
Copy link

man! this is where I am having headaches. please merge this pr to solve the v16 issue

@Anoesj
Copy link

Anoesj commented May 28, 2021

From README of package node-sass:

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

So if transitioning to Dart Sass (sass) is the way to go, node-sass shouldn't break this package when you're using the sass.compiler = require('sass'); option (because you're not actually using node-sass in that scenario). So why is node-sass a dependency at all? Why not a peer dependency or optional dependency or something? I'm not sure what would be the best solution, all I know is it's very frustrating that gulp-sass does not work on Node 16, even if you do not use node-sass at all.

@mxmason mxmason mentioned this pull request Jun 14, 2021
10 tasks
@mxmason
Copy link
Contributor

mxmason commented Jun 14, 2021

When I encountered this issue myself, I saw a few more things need to be done to ship this fix – see #802.

One of my open-source teams uses gulp-sass, and its current dependency graph is a blocker for anyone on an M1 Mac, since M1s can only run Node 16. Please consider my PR, or any PR which updates node-sass, because this is a significant blocker for M1 devices.

@xzyfer
Copy link
Collaborator

xzyfer commented Jun 15, 2021

Thanks all, close this to focus efforts on #802 which is more rounded at this point in time.

@xzyfer xzyfer closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants