Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass along sass's stats object #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WraithKenny
Copy link
Contributor

The stats object that's returned from the sass compiler contains some interesting info, particularly includedFiles which can be used to develop smarter watchers. Related to #279, fixed #428

The `stats` object that's returned from the sass compiler contains some interesting info, particularly `includedFiles` which can be used to develop smarter watchers. Related to dlmanning#279, fixed dlmanning#428
@WraithKenny
Copy link
Contributor Author

I named the property sassStats instead of stats to avoid confusion or potential collision.

@niksy
Copy link

niksy commented Sep 7, 2021

What can we do to get this merged? This would definitely help in creating smarter watchers.

@XhmikosR
Copy link
Contributor

XhmikosR commented Oct 8, 2021

I think if you extended the tests to cover this, it should help to land this. Also, this should probably be documented?

/CC @xzyfer

@niksy
Copy link

niksy commented Oct 11, 2021

@WraithKenny are you up for this?

@WraithKenny
Copy link
Contributor Author

Honestly, I've never quite figured out extending tests; I have no idea what I'm doing with regards to that. If anyone wants to adopt this issue/patch, you are more than welcome!

@XhmikosR
Copy link
Contributor

You'd need to rebase the branch first and then add 2 tests for the new property in https://github.com/dlmanning/gulp-sass/blob/master/test/main.js

@niksy
Copy link

niksy commented Jan 25, 2022

@XhmikosR @WraithKenny I’ve created new PR with tests

@XhmikosR
Copy link
Contributor

I don't have push rights, so @xzyfer will need to take care of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach stats to data object
3 participants