Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style classes to FormRenderer and SectionRenderer #14

Merged
merged 1 commit into from
Jul 5, 2018
+5 −0
Merged

Add style classes to FormRenderer and SectionRenderer #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions formsfx-core/src/main/java/com/dlsc/formsfx/view/renderer/FormRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ public void initializeParts() {
*/
@Override
public void layoutParts() {
getStyleClass().add("formsfx-form");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks too unconventional to me. We usually do not prefix style classes with the product name. Wouldn't "form" be sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the same convention found in GroupRenderer which is formsfx-group to be consistent. If "formsfx-" is removed from this PR then GroupRenderer should be updated too 😏

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, those students .... I should have kept a closer eye on their coding. :-)


setPadding(new Insets(10));
getChildren().addAll(sections);
}
Expand Down
3 changes: 3 additions & 0 deletions formsfx-core/src/main/java/com/dlsc/formsfx/view/renderer/SectionRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ public void initializeParts() {
@Override
public void layoutParts() {
super.layoutParts();

getStyleClass().add("formsfx-section");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: "section" only?


titledPane.setContent(grid);
getChildren().add(titledPane);

Expand Down