Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable additional content inside Form/Section/Group #29

Merged

Conversation

aalmiray
Copy link
Contributor

Fix for #23

WORK IN PROGRESS!!

This PR adds a new base type Element that can identify regular Fields and plain content (Node).
Instances of NodeElement can be used to attach arbitrary content to a Group within the boundaries of its grid, as shown by the following screenshot

formsfx-additional-content

The code added to the end of the Section definition is

NodeElement.of(new javafx.scene.control.Label("Somebody setup us the bomb"))
                               .span(ColSpan.HALF),
NodeElement.of(new javafx.scene.control.Label("All your forms are belong to us. What you say? Move every zig. For great justice!"))

I'm not particularly fond on the current implementation of GroupRendererBase to identify how a particular element should be rendered, as it can only identify Field and NodeElement.

Feedback welcome.

@dlemmermann dlemmermann merged commit d495a0e into dlsc-software-consulting-gmbh:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants