Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FormsFX 1.3.0, because of dlsc-software-consulting-gmbh/FormsFX#28 there is no longer a call to
getFields()
, which was replaced to a call togetElements()
instead. Also, a concept ofElement
s was introduced, whichField
now extends. The missing call caused a breaking change, since in our own implementation of a renderer, we used said call.This fix is not ideal, since it casts the
Element
s we get fromgetElement()
to aField
, which means if someone would want to define anElement
, it would throw aClassCastException
. However, it is a good tradeoff, since we currently only supportField
anyways and changingPreferencesFX
to consistently useElement
instead is a quite major refactoring, as almost all classes useField
in some form, especially including our custom renderers.