Add style classes to FormRenderer and SectionRenderer #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlemmermann
reviewed
Jul 5, 2018
| @@ -78,6 +78,8 @@ public void initializeParts() { | |||
| */ | |||
| @Override | |||
| public void layoutParts() { | |||
| getStyleClass().add("formsfx-form"); | |||
There was a problem hiding this comment.
This looks too unconventional to me. We usually do not prefix style classes with the product name. Wouldn't "form" be sufficient?
There was a problem hiding this comment.
I followed the same convention found in GroupRenderer which is formsfx-group to be consistent. If "formsfx-" is removed from this PR then GroupRenderer should be updated too 😏
There was a problem hiding this comment.
Ah, those students .... I should have kept a closer eye on their coding. :-)
dlemmermann
reviewed
Jul 5, 2018
| @@ -59,6 +59,9 @@ public void initializeParts() { | |||
| @Override | |||
| public void layoutParts() { | |||
| super.layoutParts(); | |||
|
|
|||
| getStyleClass().add("formsfx-section"); | |||
There was a problem hiding this comment.
Same here: "section" only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12