Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #27.
Field
,SimpleControl
and their subclasses.persist
,reset
,validate
) that were migrated to public as some of the subclasses had overridden the methods with public modifier.These changes will enable consumers to create custom
Field
andSimpleControl
subclasses without having to place their classes in the same package as the original FormsFX classes (a big no-no in modular codebases as split-package definition is prohibited!).In my experience implementing a library with package private in mind makes it quite hard for consumers to fill in gaps with custom implementations, it would be better to keep our options open (
protected
) but not wildly open (public
). Of course the usage of package private is a matter of taste and particular design goals that may not (or appear not to) be explicit.