Persist zoom factor = 1 cells in MongoDB and support VSI messages
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any `GET` request to `/coverage/rest/status` would fail with an NPE until a first message was received, preventing usage such as dragging the map around.
This assumes [semantic versioning](http://semver.org/) is used. The pre-release identifier `CCG` means `Canadian Coast Guard`.
See issue: [#140237535](https://www.pivotaltracker.com/story/show/140237535)
Tests sometimes timeout on Travis, so this tries to fix the issue by allowing more time to complete operations.
This allows the user to see the coverage as it was when the coverage data was last saved.
After discussion with the CCG engineer, it has been agreed that minutes are fine-grained enough for their needs.
The thread pool created with `Executors#newSingleThreadScheduledExecutor()` ensured that if the thread dies, a new one will be created for future task execution.
The previous filter would filter out too many messages, creating gaps in the canadian coverage. During winter, in the Saint-Lawrence Seaway, ships could be slowed down dramatically or stopped due to ice, but there is still a need to receive the messages and calculate coverage for these.
The canadian data shows that many messages are received with a CoG of 360, which is basically the same as 0. Since we do not filter CoGs of 0, I fail to see why we would filter out those messages with 360.
…d of processing 10000 times the same message
Modify ExportCell and JsonConverter to support VSI messages Handle display of VSI messages in map
|
The DMA logo was moved to bottom right corner, as it was sometimes getting in the way when the left panels were expanded on a small screen. |
Canadian Coast Guard prefers to have Red < 20% < Yellow <= 50% for number of messages received and Red < -107dBm < Yellow <= -101dBm for VSI coverage.
Also increase lightly side panel's size to show VSI thresholds on single line.
The previous range was too broad for actually plausible values, making slight corrections using the slider difficult to do.
The AisBus can overflow quite fast with the default configuration, so it may prove useful to configure the queue size.
Some data-related errors can be clogging logs if they happen for every packet received, making logs impossible to read. By separating errors from other log messages, it is easier to go through the logs.
This gives an idea when reading the logs about the state of the loaded data at startup.
Large window sizes such as `1000` would trigger an incorrect trimmed window size due to int arithmetic overflow.
Handling AIS packets takes time, as an AIS custom message is extracted from the packet and is added to a buffer that records the source of the message. Over time, this can lead to overflow on the AisBus side as packets are not consumed as fast as they are being received. This introduces a `received but yet unhandled` buffer on the receiver side and uses a fixed thread pool to process and remove packets stored in that buffer. A configuration option is also introduced to restrain this buffer in size and allow overflowing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Canadian Coast Guard is using this project and wanted to have data persisted in Mongo so that coverage data is not lost when the computer running the software crashes.
The simple mechanism provided in this PR simply uses a background thread to persist every X minutes, which is configurable in the
coverage-sample.xmlfile used to configure the system. The whole state of coverage data, along with a timestamp, is persisted as a Mongo document in thecoverageDatacollection of the configured database. Therefore, data can grow rather fast as the software runs for longer period of times. No prune mechanism has been added yet. Only the sliding windows pruning mechanism already there exists.Connection to the MongoDB server is kept as simple as possible: no authentication mechanism is supported right now.
When merging this PR, one should be aware that the version number in
pom.xmlnow assumes that semantic versioning is used and that theCCGpre-release identifier has been added to identify my current builds as being from the fork. I think you should keep the version number as is (unless you have your own reasons for changing the version number), but get rid of the pre-release identifier, as this will be merged in the original, official repo. A new official distribution with these changes would be greatly appreciated.Please reach out with any comments/questions :)
Thanks!