Fix a case when seek keyframe goes to eof #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lizz <lizz@sensetime.com>
zhreshold
reviewed
Jul 17, 2020
| @@ -35,7 +35,7 @@ namespace runtime { | |||
| class NDArray { | |||
| public: | |||
| // pts of the frame | |||
| int pts=0; | |||
| int pts=-1; | |||
There was a problem hiding this comment.
will pts be checked by NextFrameImpl?
There was a problem hiding this comment.
No, NextFrameImpl currently does not check this value. This value is checked in CheckKeyFrame to detect eof pattern.
BTW, how about using AV_NOPTS_VALUE constant as the init value of pts, instead of this -1?
There was a problem hiding this comment.
It's actually fine with -1, introducing AV_NOPTS_VALUE to runtime lib will add an extra dependency in the core modules.
zhreshold
approved these changes
Jul 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very rare cases, seeking keyframe might go to the end of file because currently we used the flag 0 sometimes.