We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g.update_all()
acb4eb7
Benchmark test bench_builtin_update_all_csc.py slows much down after commit acb4eb7.
dgl/benchmarks/benchmarks/api/bench_builtin_update_all_csc.py
Lines 12 to 18 in ae8cbde
u_mul_e
copy_u
I have reproduced on my local instance r6i.metal. below are details. Results on commit acb4eb7
r6i.metal
[100.00%] ··· =============== =========================== ============================ -- format / feat_size / msg_type / reduce_type --------------- -------------------------------------------------------- graph_name csc / 256 / u_mul_e / sum csc / 256 / u_mul_e / mean =============== =========================== ============================ reddit 11.187968121399171 11.947775951796212 ogbn-proteins 3.828348464198643 4.048665992595488 =============== =========================== ============================
Results on commit 29e6661
[100.00%] ··· =============== =========================== ============================ -- format / feat_size / msg_type / reduce_type --------------- -------------------------------------------------------- graph_name csc / 256 / u_mul_e / sum csc / 256 / u_mul_e / mean =============== =========================== ============================ reddit 3.305417302099522 3.3533205801039 ogbn-proteins 1.1776576915057375 1.1793251131020952 =============== =========================== ============================
Steps to reproduce the behavior:
bash script/create_dev_conda_env.sh -c -p 3.10 -s -t 1.13.1
conda activate dgl-dev-cpu
bash script/build_dgl.sh -c
cd benchmarks
DGL_HOME=/home/ubuntu/workspace/dgl_bench DGL_LIBRARY_PATH=$DGL_HOME/build PYTHONPATH=$DGL_HOME/python:$PYTHONPATH asv run -n -e --python=same --verbose --bench api.bench_builtin_update_all_csc
conda
pip
The text was updated successfully, but these errors were encountered:
@itaraban could you help look into this issue as you're the owner of #5497? This is blocking us cutting a new release of DGL.
Sorry, something went wrong.
itaraban
Successfully merging a pull request may close this issue.
🐛 Bug
Benchmark test bench_builtin_update_all_csc.py slows much down after commit
acb4eb7
.dgl/benchmarks/benchmarks/api/bench_builtin_update_all_csc.py
Lines 12 to 18 in ae8cbde
This perf issue happens for
u_mul_e
only,copy_u
works well. See more details here.I have reproduced on my local instance
r6i.metal
. below are details.Results on commit
acb4eb7
Results on commit 29e6661
To Reproduce
Steps to reproduce the behavior:
bash script/create_dev_conda_env.sh -c -p 3.10 -s -t 1.13.1
+conda activate dgl-dev-cpu
+bash script/build_dgl.sh -c
.cd benchmarks
DGL_HOME=/home/ubuntu/workspace/dgl_bench DGL_LIBRARY_PATH=$DGL_HOME/build PYTHONPATH=$DGL_HOME/python:$PYTHONPATH asv run -n -e --python=same --verbose --bench api.bench_builtin_update_all_csc
Expected behavior
Environment
conda
,pip
, source):Additional context
The text was updated successfully, but these errors were encountered: