-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add bfloat16 support for CPU #5497
Conversation
To trigger regression tests:
|
231f87b
to
56c8448
Compare
34ba5e9
to
015f570
Compare
There is still one open comment, please address, overall the code style looks great! Thanks. |
LGTM from my side, @BarclayII feel free to approve if this PR looks good to you. |
raw[0] = 0; | ||
raw[1] = val; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it assuming big endian byte order? If it's little endian I think this should be
raw[0] = val;
Also, could we have a test case on converting between bfloat16 and float32?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Description
Enabling BFloat16 data type for CPU.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes