Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Add SVDPE Transform Module #5121

Merged
merged 13 commits into from
Feb 8, 2023
Merged

[Transform] Add SVDPE Transform Module #5121

merged 13 commits into from
Feb 8, 2023

Conversation

ZhenyuLU-Heliodore
Copy link
Contributor

@ZhenyuLU-Heliodore ZhenyuLU-Heliodore commented Jan 7, 2023 •
edited
Loading

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 7, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 7, 2023

Commit ID: d344e02

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

rudongyu
rudongyu requested changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@rudongyu rudongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st round review

docs/source/api/python/transforms.rst Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/module.py Outdated Show resolved Hide resolved
@rudongyu
Copy link
Collaborator

rudongyu commented Jan 9, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 9, 2023

Commit ID: b413bbbe7ddc39e07400b4b9e93893ef604b3e26

Build ID: 2

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@ZhenyuLU-Heliodore ZhenyuLU-Heliodore changed the title [Transform] Add SvdPE Transform Module [Transform] Add SVDPE Transform Module Jan 11, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 11, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 11, 2023

Commit ID: a19847f4f0041ef3041753dd0e9efa8a0dad40b8

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2023

Commit ID: e0af97b

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2023

Commit ID: 854ff08

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2023

Commit ID: 854ff08

Build ID: 6

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 27, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 27, 2023

Commit ID: 13cfb49

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 1, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 1, 2023

Commit ID: e877c39

Build ID: 8

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 1, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 1, 2023

Commit ID: 5ce73b7

Build ID: 9

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

rudongyu commented Feb 1, 2023

@dgl-bot

@rudongyu rudongyu linked an issue Feb 2, 2023 that may be closed by this pull request
[GT] SVD Positional Encoding #5262
Closed
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 2, 2023

Commit ID: 5ce73b7

Build ID: 10

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

rudongyu
rudongyu reviewed Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@rudongyu rudongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor issues

python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Show resolved Hide resolved
python/dgl/transforms/module.py Show resolved Hide resolved
python/dgl/transforms/module.py Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Commit ID: 1945619

Build ID: 11

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Commit ID: 502b4ca

Build ID: 12

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Commit ID: f710257

Build ID: 13

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Commit ID: f4f17d3

Build ID: 14

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

rudongyu commented Feb 6, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 6, 2023

Commit ID: f4f17d3

Build ID: 15

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@rudongyu rudongyu merged commit 5598503 into dmlc:master Feb 8, 2023
@ZhenyuLU-Heliodore ZhenyuLU-Heliodore deleted the add_svdpe branch March 6, 2023 12:56
paoxiaode pushed a commit to paoxiaode/dgl that referenced this pull request Mar 24, 2023
@ZhenyuLU-Heliodore @paoxiaode
[Transform] Add SVDPE Transform Module (dmlc#5121)
1e40ad2 
* add SVD positional encoding

* modify importing module

* Fixed certain problems

* Change the test unit to a nonsigular one

* Fixed typo and make accord with lintrunner

* added svd_pe into dgl.rst

* Modified dgl.rst
czkkkkkk pushed a commit that referenced this pull request Apr 19, 2023
@ZhenyuLU-Heliodore @czkkkkkk
[Transform] Add SVDPE Transform Module (#5121)
394c0fd 
* add SVD positional encoding

* modify importing module

* Fixed certain problems

* Change the test unit to a nonsigular one

* Fixed typo and make accord with lintrunner

* added svd_pe into dgl.rst

* Modified dgl.rst
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
@ZhenyuLU-Heliodore @DominikaJedynak
[Transform] Add SVDPE Transform Module (dmlc#5121)
3784122 
* add SVD positional encoding

* modify importing module

* Fixed certain problems

* Change the test unit to a nonsigular one

* Fixed typo and make accord with lintrunner

* added svd_pe into dgl.rst

* Modified dgl.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudongyu rudongyu rudongyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GT] SVD Positional Encoding
3 participants
@ZhenyuLU-Heliodore @dgl-bot @rudongyu