Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset] Add PATTERN dataset #5422

Merged
merged 8 commits into from
Mar 8, 2023
Merged

[Dataset] Add PATTERN dataset #5422

merged 8 commits into from
Mar 8, 2023

Conversation

gyzhou2000
Copy link
Contributor

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Commit ID: 75f0e10

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu rudongyu self-requested a review March 6, 2023 02:45
@rudongyu
Copy link
Collaborator

rudongyu commented Mar 6, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Commit ID: b815a44

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Commit ID: 75f0e10

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 7, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 7, 2023

Commit ID: 4ff47714d23024bed20eb2a636ecb6906cb2ad42

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

rudongyu
rudongyu requested changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@rudongyu rudongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except a few minor issues.

python/dgl/data/pattern.py Outdated Show resolved Hide resolved
python/dgl/data/pattern.py Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Commit ID: 70dbfd7

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Commit ID: 64eea7a

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

rudongyu commented Mar 8, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Commit ID: 2f2e5c2

Build ID: 9

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

rudongyu commented Mar 8, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Commit ID: 2f2e5c2

Build ID: 8

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

rudongyu commented Mar 8, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Commit ID: 2f2e5c2

Build ID: 10

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 8, 2023

Commit ID: 2f2e5c2

Build ID: 11

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@rudongyu rudongyu merged commit 1782902 into dmlc:master Mar 8, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
@gyzhou2000 @rudongyu @DominikaJedynak
[Dataset] Add PATTERN dataset (dmlc#5422)
8011c0a 
* add PATTERN dataset

* fix bug

* fix bugs

* fix issues

* refine according to dongyu's comments

---------

Co-authored-by: BuptTab <gyzhou2000@gmail.com>
Co-authored-by: rudongyu <ru_dongyu@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudongyu rudongyu rudongyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gyzhou2000 @dgl-bot @rudongyu