Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sparse] Add compact operator #6352

Merged
merged 23 commits into from
Oct 9, 2023
Merged

Conversation

xiangyuzhi
Copy link
Collaborator

@xiangyuzhi xiangyuzhi commented Sep 19, 2023

Description

Sparse compact operator implementation.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 19, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@xiangyuzhi xiangyuzhi requested a review from czkkkkkk September 19, 2023 14:25
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 19, 2023

Commit ID: 5a7558a

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 19, 2023

Commit ID: d0d5032

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 22, 2023

Commit ID: ea2cf72b780e76df040620b82c69f4c993951990

Build ID: 3

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 22, 2023

Commit ID: 95e0cc8c23bf0eb72b26411fe77c093403a9a225

Build ID: 4

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 22, 2023

Commit ID: a38eb3dd4ec1b4d7dd750ff7929fe1c89576a0a3

Build ID: 5

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

dgl_sparse/src/utils.h Outdated Show resolved Hide resolved
dgl_sparse/src/macro.h Outdated Show resolved Hide resolved
dgl_sparse/src/cpu/matrix_ops_impl.cc Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 25, 2023

Commit ID: 5082f5c8f9fd2e392418bf5fab6908e77c6a3260

Build ID: 6

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@czkkkkkk czkkkkkk changed the title [Sparse] Compact CPU implementation [Sparse] Add compact operator Sep 25, 2023
dgl_sparse/include/sparse/matrix_ops.h Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 25, 2023

Commit ID: 9839faea74690c7b2707fa8b6b85605135ad26f6

Build ID: 7

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 25, 2023

Commit ID: f09fb6222e25278e39c1433ea45afda294d4cf9e

Build ID: 8

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 25, 2023

Commit ID: f38374ec826044e206a572f54aeee2723e1c5237

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 25, 2023

Commit ID: 146eae9b1fd952135e1db02385e301705f0d7bba

Build ID: 10

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 26, 2023

Commit ID: 1da6a46f8083ee248b506eb7a691d3a792422426

Build ID: 11

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 26, 2023

Commit ID: 7c4724fac65c5c19bb1469645b9a22839a9c71a2

Build ID: 12

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 26, 2023

Commit ID: 40585404b775a8210b80312ec947fc061bd6afb9

Build ID: 13

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi requested a review from czkkkkkk September 26, 2023 09:13
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
tests/python/pytorch/sparse/test_matrix_op.py Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/utils.h Outdated Show resolved Hide resolved
@xiangyuzhi xiangyuzhi requested a review from czkkkkkk October 8, 2023 07:33
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 8, 2023

Commit ID: 92486144df104b6e4efe6a38adf5706a50a52827

Build ID: 14

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Copy link
Collaborator

@czkkkkkk czkkkkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

dgl_sparse/src/matrix_ops.cc Outdated Show resolved Hide resolved
dgl_sparse/src/matrix_ops.cc Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 8, 2023

Commit ID: 042615d051f22348ee24555fbfa8ac415e90529a

Build ID: 15

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 8, 2023

Commit ID: e0275b746f667ebd0f35061202d21977386ec817

Build ID: 16

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi merged commit fdb4737 into dmlc:master Oct 9, 2023
1 check passed
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
Co-authored-by: Ubuntu <ubuntu@ip-172-31-24-117.ap-northeast-1.compute.internal>
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Co-authored-by: Ubuntu <ubuntu@ip-172-31-24-117.ap-northeast-1.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants