-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc.] Avoid calling IsPinned
in the coo/csr constructor from every sampling process
#6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
chang-l
changed the title
[CPU-sampling] Avoid calling
[Misc.] Avoid calling Nov 15, 2023
IsPinned
in the coo/csr constructor from every sampling processIsPinned
in the coo/csr constructor from every sampling process
nv-dlasalle
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in general it looks good, but as I noted I think the IsPinned()
function should be changed.
frozenbugs
approved these changes
Nov 22, 2023
peizhou001
pushed a commit
to peizhou001/dgl
that referenced
this pull request
Nov 27, 2023
…y sampling process (dmlc#6568)
DominikaJedynak
pushed a commit
to DominikaJedynak/dgl
that referenced
this pull request
Mar 12, 2024
…y sampling process (dmlc#6568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #6561.
It moves the
IsPinned
checking block out of the coo/csr constructor, to avoid initialize cuda instances at sampling(child) processes and align with PyTorch dataloader convention.Checklist
Please feel free to remove inapplicable items for your PR.