-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt][CUDA] Enable GPU sampling in examples #6861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
27 tasks
mfbalin
requested review from
frozenbugs,
Skeleton003,
keli-wen and
Rhett-Ying
December 28, 2023 20:34
Skeleton003
reviewed
Dec 28, 2023
mfbalin
commented
Jan 16, 2024
frozenbugs
reviewed
Jan 16, 2024
frozenbugs
reviewed
Jan 16, 2024
frozenbugs
reviewed
Jan 16, 2024
frozenbugs
reviewed
Jan 16, 2024
frozenbugs
reviewed
Jan 16, 2024
frozenbugs
reviewed
Jan 16, 2024
mfbalin
force-pushed
the
gb_cuda_examples
branch
from
January 16, 2024 07:42
b6fb51e
to
61441e7
Compare
mfbalin
force-pushed
the
gb_cuda_examples
branch
from
January 16, 2024 07:43
61441e7
to
bbbcd49
Compare
frozenbugs
approved these changes
Jan 16, 2024
frozenbugs
approved these changes
Jan 16, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making modifications to enable GPU sampling in the graphbolt examples. All modified examples seem to just work, haven't tested the multi-GPU lightning scenario yet (
num_gpus > 1
). I would appreciate it if you could help see if they all work and match the CPU sampling results.Depends on #6957.
Google colab demo here: https://colab.research.google.com/drive/1AMnK9YlEP5dSWiz1Kg6V6DdVjsiSeN75?usp=sharing