Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Modify multiGPU example to use GPU sampling. #6961

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jan 16, 2024

Description

Modified the example to utilize GPU sampling. We need to fix the replication problem due to the use of torch pin_memory.

Here is a discussion about how we can fix the process graph and feature duplication issue: pytorch/pytorch#32167
The fix is in #6962.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 16, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 16, 2024

Commit ID: deb3e41

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2024

Commit ID: 1063706

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2024

Commit ID: a067a89

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from frozenbugs January 17, 2024 07:59
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2024

Commit ID: 1786338

Build ID: 4

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Jan 17, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 17, 2024

Commit ID: 1786338

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 78fa316 into dmlc:master Jan 18, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_multigpu_example branch January 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants