Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] GPUCachedFeature for multiGPU example. #7074

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Feb 2, 2024

Description

Adding GPUCache option to the multiGPU example. Helps performance tremendously, might get linear scaling on multiGPU machines now, with --gpu-cache-size=1000000. Later, when we have a larger scale dataset in this example, this option will be the key to good performance.

I think the multiGPU example should demonstrate all the good practices recommended by us for optimal performance, hence the GPUCache should be available as an option here. Because one needs multiple GPUs when the performance with a single GPU is not sufficient.

Fixes #6955. Depends on #7073.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 2, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 2, 2024

Commit ID: a5453d4

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@TristonC TristonC merged commit 0a42d86 into dmlc:master Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphBolt][CUDA] Showcase GPUCachedFeature usage in an example.
3 participants