-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] torch.compile()
support for gb.expand_indptr
.
#7188
Conversation
To trigger regression tests:
|
There is an issue, I hope pytorch developers can help fix it: pytorch/pytorch#121080 |
@mfbalin can you fix the build? |
I can not, we need to start depending on Torch 2.2 instead of 2.0. The CI needs to be updated. |
We are deprecating Torch 1.3 (oldest Torch version: 2.0) in DGL 2.1, likely we will not move to 2.2 in near future. If it requires 2.2, let's table the change until then? |
Sure. Which release of DGL do you think will move to 2.2 do you think? |
Also, it may be possible to still get this PR through by adding version checks on certain parts of the code. I will see if it is easily doable. Then, maybe we won't have to wait that long. |
The CI will hopefully pass now. |
@frozenbugs got the CI to pass. I think it is ready to review. |
@Rhett-Ying Can we add torch 2.2 to the CI also so that the code that is enabled only for 2.2 can be tested? For now, I tested locally with a docker container that has |
Description
Details in this document by PyTorch developers: https://docs.google.com/document/d/1W--T6wz8IY8fOI0Vm8BF44PdBgs283QvpelJZWieQWQ/edit?usp=sharing
This PR utilizes
torch>=2.2.0
features.Checklist
Please feel free to remove inapplicable items for your PR.
Changes