-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDA] Make sanity check optional for dgl.create_block
.
#7240
Merged
frozenbugs
merged 4 commits into
dmlc:master
from
mfbalin:dgl_create_block_synch_eliminate
Mar 26, 2024
Merged
[CUDA] Make sanity check optional for dgl.create_block
.
#7240
frozenbugs
merged 4 commits into
dmlc:master
from
mfbalin:dgl_create_block_synch_eliminate
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfbalin
force-pushed
the
dgl_create_block_synch_eliminate
branch
from
March 24, 2024 16:56
bb989f9
to
7bd258f
Compare
To trigger regression tests:
|
mfbalin
force-pushed
the
dgl_create_block_synch_eliminate
branch
from
March 24, 2024 20:57
c4f323f
to
bf587d4
Compare
frozenbugs
reviewed
Mar 25, 2024
frozenbugs
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The hetero sampling case has too many GPU synchronizations, we need to hunt them down one by one if we want to get good performance.
I would appreciate any help in this direction as some of these are inside DGL itself, not GraphBolt.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes