[GraphBolt][CUDA] Compute capability check refactor. #7485

mfbalin · 2024-06-26T21:07:35Z

Description

Utilize existing cub function to get compute capability in a cached manner using https://nvidia.github.io/cccl/cub/api/function_namespacecub_1a75d6eade310f187ff42915ae82e963d0.html

Checklist

Please feel free to remove inapplicable items for your PR.

The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
I've leverage the tools to beautify the python and c++ code.
The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
All changes have test coverage
Code is well-documented
To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
Related issue is referred in this PR
If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot · 2024-06-26T21:08:03Z

To trigger regression tests:

@dgl-bot run [instance-type] [which tests] [compare-with-branch];
For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot · 2024-06-26T21:22:58Z

Commit ID: 17fabf7

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T21:52:42Z

Commit ID: d480448

Build ID: 2

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T21:53:27Z

@dgl-bot

dgl-bot · 2024-06-26T22:24:29Z

Commit ID: d480448

Build ID: 3

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T22:25:15Z

@dgl-bot

dgl-bot · 2024-06-26T22:56:04Z

Commit ID: d480448

Build ID: 4

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T23:00:43Z

@dgl-bot

dgl-bot · 2024-06-26T23:31:43Z

Commit ID: d480448

Build ID: 5

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T23:32:30Z

@dgl-bot

mfbalin · 2024-06-26T23:33:07Z

@Rhett-Ying

tests/distributed/test_mp_dataloader.py::test_edge_dataloader_heterograph[False-None-True-0] Fatal Python error: Segmentation fault

Thread 0x00007f90b2e5e700 (most recent call first):
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 324 in wait
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 607 in wait
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/tqdm/_monitor.py", line 60 in run
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 973 in _bootstrap

Current thread 0x00007f90e0361800 (most recent call first):
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/codecs.py", line 322 in decode
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7485/python/dgl/partition.py", line 271 in get_peak_mem
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7485/python/dgl/distributed/partition.py", line 921 in partition_graph
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7485/tests/distributed/test_mp_dataloader.py", line 770 in check_dataloader
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7485/tests/distributed/test_mp_dataloader.py", line 989 in test_edge_dataloader_heterograph
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/python.py", line 162 in pytest_pyfunc_call
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/python.py", line 1627 in runtest
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 173 in pytest_runtest_call
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 241 in &lt;lambda&gt;
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 341 in from_call
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 240 in call_and_report
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 135 in runtestprotocol
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 116 in pytest_runtest_protocol
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 364 in pytest_runtestloop
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 339 in _main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 285 in wrap_session
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 332 in pytest_cmdline_main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/config/__init__.py", line 178 in main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/config/__init__.py", line 206 in console_main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pytest/__main__.py", line 7 in &lt;module&gt;
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/runpy.py", line 86 in _run_code
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/runpy.py", line 196 in _run_module_as_main

dgl-bot · 2024-06-27T00:03:17Z

Commit ID: d480448

Build ID: 6

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-27T00:30:52Z

@dgl-bot

dgl-bot · 2024-06-27T01:01:56Z

Commit ID: d480448

Build ID: 7

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-27T01:02:43Z

@dgl-bot

dgl-bot · 2024-06-27T01:36:03Z

Commit ID: d480448

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

[GraphBolt][CUDA] Compute capability check refactor.

17fabf7

mfbalin requested review from frozenbugs and Rhett-Ying June 26, 2024 21:07

simplify

d480448

mfbalin mentioned this pull request Jun 26, 2024

[CI] Spurious test failures #7481

Open

frozenbugs approved these changes Jun 27, 2024

View reviewed changes

mfbalin merged commit c74a5c8 into dmlc:master Jun 27, 2024
2 checks passed

mfbalin deleted the gb_cuda_sm_check_refactor branch June 27, 2024 01:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GraphBolt][CUDA] Compute capability check refactor. #7485

[GraphBolt][CUDA] Compute capability check refactor. #7485

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 27, 2024

mfbalin commented Jun 27, 2024

dgl-bot commented Jun 27, 2024

mfbalin commented Jun 27, 2024

dgl-bot commented Jun 27, 2024

[GraphBolt][CUDA] Compute capability check refactor. #7485

[GraphBolt][CUDA] Compute capability check refactor. #7485

Conversation

mfbalin commented Jun 26, 2024

Description

Checklist

Changes

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 27, 2024

mfbalin commented Jun 27, 2024

dgl-bot commented Jun 27, 2024

mfbalin commented Jun 27, 2024

dgl-bot commented Jun 27, 2024