Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Async feature fetch refactor #7540

Merged
merged 35 commits into from
Jul 22, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 18, 2024

Description

@frozenbugs can you take a look at the overall API and let me know how it looks? I will separate into small PRs later, this is a draft PR.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin marked this pull request as draft July 18, 2024 16:50
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: de5c5ea

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 3255817

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 7fcc4b4

Build ID: 3

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 83099bc

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 79e4e2f

Build ID: 5

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from frozenbugs July 18, 2024 18:43
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 5b2bf55

Build ID: 6

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 1d49dc8

Build ID: 7

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 10ba72c

Build ID: 8

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 9f40899

Build ID: 9

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 537b815

Build ID: 10

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 2dc96d9

Build ID: 11

Status: ❌ CI test failed in Stage [Torch CPU Unit test].

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Jul 18, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 2dc96d9

Build ID: 12

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Jul 18, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 18, 2024

Commit ID: 2dc96d9

Build ID: 13

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: f3f5733

Build ID: 27

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: a62395e

Build ID: 28

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: 9161bf9

Build ID: 29

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: 05f9a86

Build ID: 30

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: 49283ef

Build ID: 31

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: 2c19798

Build ID: 32

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: da4d20a

Build ID: 33

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as ready for review July 20, 2024 21:06
@mfbalin
Copy link
Collaborator Author

mfbalin commented Jul 20, 2024

@frozenbugs, I have merged the contents of this PR in 10 other PRs. If you review them and let me know suggestions and improvements, I can address the reviews in this PR and we can merge this one too.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 20, 2024

Commit ID: 42e5194

Build ID: 34

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Jul 22, 2024

@frozenbugs I have address your reviews in this initial PR. Further review comments can be addressed in this PR too.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: b21951b25604e4fd02d298d108d81c513ccef945

Build ID: 35

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: d9c73e9

Build ID: 36

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 5b4635a into dmlc:master Jul 22, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_async_feature_fetch branch July 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants