Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Per-thread RandomEngine initialization fix. #7557

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 21, 2024

Description

Also remove unnecessary dependency on dmlc just for thread local. I have tested and each threads gets their own engines. Each run results in different random numbers for each thread because manual_seed gets initialized randomly.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested review from frozenbugs and Rhett-Ying July 21, 2024 05:59
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin mfbalin changed the title [GraphBolt] RandomEngine thread_local creation fix. [GraphBolt] Per-thread RandomEngine initialization fix. Jul 21, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

Commit ID: 25d444e

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit c83acdd into dmlc:master Jul 22, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_random_engine_fix branch July 22, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants