Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] CachePolicy Writer lock for read_async correctness. #7581

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 24, 2024

Description

In async feature loading pipeline, after we insert into the policy, values may not be still written into the cache yet. Using writer locks in addition to reader locks, we can act as if inserted values whose payload has not been inserted yet do not exist during our reads.

The PR is a bit large because I needed to do the change for all 4 cache policies at once.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Jul 24, 2024
@mfbalin mfbalin requested a review from frozenbugs July 24, 2024 22:07
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 24, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 24, 2024

Commit ID: df2fe6d

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit b8604a5 into dmlc:master Jul 24, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cpu_cache_writer_lock branch July 24, 2024 23:02
@frozenbugs
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants