[GraphBolt][CUDA] gb.indptr_edge_ids.
#7592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfbalin
added
the
expedited
|
To trigger regression tests:
|
8 tasks
frozenbugs
reviewed
Jul 30, 2024
| torch::optional<torch::Tensor> nodes, | ||
| torch::optional<int64_t> output_size) { | ||
| torch::optional<torch::Tensor> nodes, torch::optional<int64_t> output_size, | ||
| const bool edge_ids) { |
There was a problem hiding this comment.
include edge ids? has edge ids?
There was a problem hiding this comment.
Alright, let me change to a better name.
mfbalin
added a commit
to mfbalin/dgl-1
that referenced
this pull request
Jul 30, 2024
frozenbugs
pushed a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we use overlap_graph_fetch, the returned edge ids belong to the sliced subgraph, which is wrong. This op will help fix this issue.
The line count is a bit large because of the copy paste of the docstrings and the test code from expand_indptr. Otherwise, most of it should be easy to review.
EDIT: Moved python parts to next PR for easier review.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes