-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt][CUDA] Async sample neighbors and compaction. #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
To trigger regression tests:
|
mfbalin
force-pushed
the
gb_cuda_async_sample_neighbors
branch
from
August 13, 2024 02:56
76b766d
to
3c76e58
Compare
8 tasks
mfbalin
added
the
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
label
Aug 14, 2024
6 tasks
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to hide the latency of GPU CPU synchronization using pipelining. We want to eliminate the white gaps in the profile below:
Before:
After:
This is going to be achieved by using pipelining so that the output of one stage is not required by the next. Then, we can launch kernels for all stages at the same time in an async manner, ensuring there are no white gaps.
Preliminary results:
Without torch.compile
Without asynchronous: 1.51s
With asynchronous: 1.37s
With torch.compile:
Without asynchronous: 1.11s
WIth asynchronous: 0.98s
Checklist
Please feel free to remove inapplicable items for your PR.
Changes