-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt][CUDA] Eliminate synchronization for overlap_graph_fetch
.
#7709
Merged
mfbalin
merged 5 commits into
dmlc:master
from
mfbalin:gb_cuda_async_overlap_graph_fetch
Aug 16, 2024
Merged
[GraphBolt][CUDA] Eliminate synchronization for overlap_graph_fetch
.
#7709
mfbalin
merged 5 commits into
dmlc:master
from
mfbalin:gb_cuda_async_overlap_graph_fetch
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfbalin
added
the
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
label
Aug 16, 2024
To trigger regression tests:
|
mfbalin
removed
the
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
label
Aug 16, 2024
8 tasks
mfbalin
added
the
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
label
Aug 16, 2024
LGTM. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When fetching insubgraph in the pinned case, we make sure to eliminate the CPU GPU synchronization.
With the asynchronous PRs, finally the GPU Graph Cache helps both neighbor sampler and layer neighbor sampler.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes