-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] Make CachePolicy
hetero capable [1]
#7723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
mfbalin
added
the
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
label
Aug 20, 2024
mfbalin
changed the title
[GraphBolt] Make
[GraphBolt] Make Aug 20, 2024
CachePolicy
hetero capable.CachePolicy
hetero capable [1]
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cache will be constructed first (applies to both CPU and GPU). The GPUCachedFeature and CPUCachedFeature will have an
_offset
field that is set to 0 by default (no effect). When it is nonzero, the keys will be offset by the_offset
field according to the node_type_offset in FusedCSCSamplingGraph. Then, the same cache can be used for hetero features that have the same dimensions.Checklist
Please feel free to remove inapplicable items for your PR.
Changes