Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Make CachePolicy hetero capable [1] #7723

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Aug 20, 2024

Description

The cache will be constructed first (applies to both CPU and GPU). The GPUCachedFeature and CPUCachedFeature will have an _offset field that is set to 0 by default (no effect). When it is nonzero, the keys will be offset by the _offset field according to the node_type_offset in FusedCSCSamplingGraph. Then, the same cache can be used for hetero features that have the same dimensions.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin marked this pull request as draft August 20, 2024 04:44
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

Commit ID: f4f5a0a

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

Commit ID: df89b5d

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

Commit ID: 430f0f6

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

Commit ID: 0152e92

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

Commit ID: 349b0d9

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as ready for review August 20, 2024 17:12
@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Aug 20, 2024
@mfbalin mfbalin requested a review from frozenbugs August 20, 2024 17:26
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

Commit ID: 435cf94

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 20, 2024

Commit ID: 3e20ace4301c108d9ab5426f0a872aee98bc8d82

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin changed the title [GraphBolt] Make CachePolicy hetero capable. [GraphBolt] Make CachePolicy hetero capable [1] Aug 20, 2024
@mfbalin mfbalin merged commit aca40c8 into dmlc:master Aug 20, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_hetero_cache_policy branch August 20, 2024 18:38
@frozenbugs
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants