Add OMPException class and use it for Text Parser #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@anirudh2290 Can you use this for |
|
@hcho3 yes you should be able to use it and i am using it in the related PR for mxnet https://github.com/apache/incubator-mxnet/pull/12051/files |
|
@hcho3 does that answer your question ? is this PR good to go ? |
|
@anirudh2290 Let me review it today. |
hcho3
approved these changes
Aug 15, 2018
src/data/text_parser.h
Outdated
| parser_exception_ = std::current_exception(); | ||
| } | ||
| } | ||
| omp_exc_.Run([=] { |
There was a problem hiding this comment.
I'm a bit wary about the default value capture here. For example, is it cheap to copy chunk?
I think we should stick to capture by reference [&], since there is no danger of the lambda outliving the captured objects.
There was a problem hiding this comment.
good point. you are right it should be by reference. i fixed it at other places in mxnet code but missed it here.
|
LGTM |
hcho3
pushed a commit
that referenced
this pull request
Aug 15, 2018
* Add OMPException class and use it for Text Parser * Fix lint * Add documentation for Rethrow and Run * Fix lint * Add documentation for OMPException * Add more documentation * Fix comments * Change capture by value to capture by reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a class for OMPException since this needs to be handled in TextParser in dmlc-core and also the ImageDetRecordIOParser, ImageRecordIOParser and other parsers that maybe added in future in MXNet.