-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RABIT_DLL tag to definitions of rabit APIs. #140
Conversation
Thanks for fast investigation. Unfortunately I still have this I fetch your changes for rabit repo, and used docker build: |
@ShvetsKS I will come back to this next week. It's weird as now our pip package is by default built with hidden symbols. Also I tried the docker build last week .. |
some remark: if I use 1.1.0RC2/RC1 I can run my benchmark and there is no such error ( |
@ShvetsKS RC2 should be built hidden symbols as it was to fix a bug where dmlc-core from xgboost clashes with dmlc-core from tvm. Could you try running |
Sorry, my bad. Rebased onto master. |
It should work now. |
Closes #137 . |
@ShvetsKS Could you try
-DHIDE_CXX_SYMBOLS=ON
again with this patch enabled?Related: dmlc/xgboost#5666 (comment)