[rabit harden] fix rabit tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenqin
changed the title
chenqin
changed the title
|
you can consider temporarily point dmlc-core in this PR to your private branch to have a cross-check before we merge any of them |
added 2 commits
March 7, 2019 18:08
This reverts commit 0eba614.
CodingCat
reviewed
Mar 8, 2019
chenqin
changed the title
|
passing test locally with gcc-7/g++-7 on osx 10.14.3. |
|
^^ @CodingCat @hcho3 |
This was referenced Mar 11, 2019
|
Passed integration tests in xgboost side |
CodingCat
reviewed
Mar 12, 2019
|
passing XGBoost tests |
|
@trivialfis Can you help merge this? should be straight forward pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice, this pr will fail test unless dmlc-core local tracker pr landed. dmlc/dmlc-core#510
This first pr of series of prs in order to harden rabit and make sure the tests running with meaningful test coverage. The goal of this pr is to enable model recover tests which simulate worker failure and resume (catchup with next allreduce) expected behavior in guide doc
What this pr does is basically working along side with local tracker pr and pass latest command into rabit init; remove duplicated ntrail value overwrite from DMLC_NUM_ATTEMPT; add console output when worker recovered/catchup in allreduce.