Fix Windows 2016 build. (#5902)

dmlc · Jul 17, 2020 · 6c0c872 · 6c0c872
1 parent 71b0528
commit 6c0c872
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/jvm-packages/create_jni.py b/jvm-packages/create_jni.py
@@ -80,7 +80,7 @@ def normpath(path):
         with cd("build"):
             if sys.platform == "win32":
                 # Force x64 build on Windows.
-                maybe_generator = ' -G"Visual Studio 14 Win64"'
+                maybe_generator = ' -A x64'
             else:
                 maybe_generator = ""
             if sys.platform == "linux":

diff --git a/python-package/setup.py b/python-package/setup.py
@@ -153,6 +153,8 @@ def build_cmake_extension(self):
                         '%s is used for building Windows distribution.', vs)
                     break
                 except subprocess.CalledProcessError:
+                    shutil.rmtree(build_dir)
+                    os.mkdir(build_dir)
                     continue
         else:
             gen = '-GNinja' if build_tool == 'ninja' else '-GUnix Makefiles'

diff --git a/src/common/charconv.cc b/src/common/charconv.cc
@@ -37,11 +37,6 @@
 
 #if defined(_MSC_VER)
 #include <intrin.h>
-namespace {
-inline int32_t __builtin_clzll(uint64_t x) {
-  return static_cast<int32_t>(__lzcnt64(x));
-}
-}  // anonymous namespace
 #endif
 
 /*
@@ -288,8 +283,13 @@ struct RyuPowLogUtils {
     return MulShift(m, kFloatPow5Split[i], j);  // NOLINT
   }
 
-  static uint32_t FloorLog2(const uint64_t value) {
-    return 63 - __builtin_clzll(value);
+  static uint32_t FloorLog2(const uint32_t value) {
+#if defined(_MSC_VER)
+    unsigned long index;  // NOLINT
+    return _BitScanReverse(&index, value) ? index : 32;
+#else
+    return 31 - __builtin_clz(value);
+#endif
   }
 
   /*