Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jvm-package] Incorrect number of weights and groups in ranking test. #4117

Closed
trivialfis opened this issue Feb 8, 2019 · 2 comments · Fixed by #4118
Closed

[jvm-package] Incorrect number of weights and groups in ranking test. #4117

trivialfis opened this issue Feb 8, 2019 · 2 comments · Fixed by #4118

Comments

@trivialfis
Copy link
Member

While working on #4115, @hcho3 pointed out the test in scala ranking is incorrect: #4115 (comment)

The number of groups should be equal to number of weights but my added check shows otherwise:
https://travis-ci.org/dmlc/xgboost/jobs/490661939#L1557

@CodingCat Could you make a separated PR so that I can rebase on?
@CodingCat
Copy link
Member

ack doing it today

@trivialfis
Copy link
Member Author

Thanks!

@CodingCat CodingCat mentioned this issue Feb 9, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jvm-packages] force use per-group weights in spark layer CodingCat/xgboost
2 participants
@CodingCat @trivialfis