Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Makefile based build system #4899

Closed
codingforfun opened this issue Sep 26, 2019 · 5 comments
Closed

Remove Makefile based build system #4899

codingforfun opened this issue Sep 26, 2019 · 5 comments

Comments

@codingforfun
Copy link

Is there a valid reason to keep the Makefiles? They seam to be historic and nowadays everythings is build using CMake. Correct me if I missed something.
@codingforfun codingforfun mentioned this issue Sep 26, 2019
Closed
9 tasks
@trivialfis
Copy link
Member

R package for cran...

@trivialfis
Copy link
Member

@codingforfun Feel free to reopen if you have experience on getting CMake to pass cran build.

@hcho3
Copy link
Collaborator

hcho3 commented Sep 26, 2019

@trivialfis @codingforfun The issue is that R packaging system is stuck using Makefile as build system. We can try to call CMake from the Makefile; however, not every target required by the CRAN policy (see the list here) appears to have CMake installed.

@codingforfun
Copy link
Author

codingforfun commented Sep 26, 2019 •
edited
Loading

Ok. I understand. I missed that. Sorry for the noise.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
@dmlc dmlc unlocked this conversation Apr 11, 2020
@hcho3
Copy link
Collaborator

hcho3 commented Apr 11, 2020

#5513 removes Makefile completely, except for convenience tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codingforfun @hcho3 @trivialfis