-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect install interface, result the package is not relocatable #6734
Comments
Thanks for pointing that out @kangsheng89 . Would you like to open a PR for addressing the issue? |
kangsheng89
added a commit
to kangsheng89/xgboost
that referenced
this issue
Feb 27, 2021
@trivialfis please review the changes! Thanks |
trivialfis
pushed a commit
that referenced
this issue
Feb 27, 2021
Thanks for the PR! |
Welcome!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xgboost/CMakeLists.txt
Line 206 in 1fa6793
This line of INSTALL_INTERFACE is wrong and not relocatable. This will result that INTERFACE_INCLUDE_DIRECTORIES set as hardcoded path based on CMAKE_INSTALL_PREFIX from Build Machine
please refer to this https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-relocatable-packages
preferable to use as:
$<INSTALL_INTERFACE:$ <INSTALL_PREFIX>/include>
The text was updated successfully, but these errors were encountered: