Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect install interface, result the package is not relocatable #6734

Closed
kangsheng89 opened this issue Feb 26, 2021 · 4 comments
Closed

Comments

@kangsheng89
Copy link
Contributor

$<INSTALL_INTERFACE:${CMAKE_INSTALL_PREFIX}/include>

This line of INSTALL_INTERFACE is wrong and not relocatable. This will result that INTERFACE_INCLUDE_DIRECTORIES set as hardcoded path based on CMAKE_INSTALL_PREFIX from Build Machine

please refer to this https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-relocatable-packages

preferable to use as:
$&lt;INSTALL_INTERFACE:$&lt;INSTALL_PREFIX>/include>

@trivialfis
Copy link
Member

Thanks for pointing that out @kangsheng89 . Would you like to open a PR for addressing the issue?

@kangsheng89
Copy link
Contributor Author

@trivialfis please review the changes! Thanks

@trivialfis
Copy link
Member

Thanks for the PR!

@kangsheng89
Copy link
Contributor Author

Welcome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants