Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control logging for early stopping using shouldPrint() XGBoost.java #7290

Closed
steveychong opened this issue Oct 7, 2021 · 2 comments
Closed

Control logging for early stopping using shouldPrint() XGBoost.java #7290

steveychong opened this issue Oct 7, 2021 · 2 comments
Labels
feature-request

Comments

@steveychong
Copy link

steveychong commented Oct 7, 2021 •
edited
Loading

version: xgboost4j_2.2:1.4.1
code: XGBoost.java
In XGBoost.java, if there is an early stop in processing, a Log is output by Rabit.trackerPrint() (line 254).

It might be better wrap this message in an "if(shouldPrint(params, iter))" check so that the logging is consistent with other logging (e.g. line 261).
@nicovdijk nicovdijk mentioned this issue Oct 15, 2021
Merged
@nicovdijk
Copy link
Contributor

nicovdijk commented Oct 15, 2021 •
edited
Loading

I added a pull request #7326 for the fix that @steveychong suggested.

@trivialfis
Copy link
Member

Closed by #7326. Thanks @nicovdijk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trivialfis @nicovdijk @steveychong