Suggestion for "Control logging for early stopping using shouldPrint() XGBoost.java" #7326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7326 +/- ##
==========================================
+ Coverage 82.64% 83.62% +0.98%
==========================================
Files 13 13
Lines 4067 3884 -183
==========================================
- Hits 3361 3248 -113
+ Misses 706 636 -70
Continue to review full report at Codecov.
|
trivialfis
approved these changes
Oct 20, 2021
|
@wbo4958 Do you need to take a look? |
wbo4958
reviewed
Oct 20, 2021
jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/XGBoost.java
Outdated
Show resolved
Hide resolved
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #7290.