[R] Rename ProxyDMatrix -> DataBatch #10016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
approved these changes
Jan 30, 2024
|
The change makes sense. Please help rebase the PR. |
This is very odd. I don't get any merge conflict when merging the latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
As a follow up from #9913
I had second thoughts on the naming using internally and externally.
Currently, the
DataItercallback needs to return aProxyDMatrix, and internally, it uses aProxyDMatrixHandle, which is quite unintuitive.This PR renames them so that the object that needs to be passed to the iterator is now
DataBatch, and the internal object (which is not exposed to the user) is namedProxyDMatrix.Along the way, it fixes some tests to not accept function arguments that were removed during internal changes in the previous PR.