[R] Rename slice -> xgb.slice.DMatrix #10017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
Currently, xgboost registers an S3 method "slice", and defines it for the DMatrix class.
This is problematic in R, since a widely used library, {dplyr}, also defines a generic
slicemethod with implementations for data frames and variants, and extensions like {dbplyr} and similar define it for more object classes based on dplyr's signature.This PR renames it to
xgb.slice.DMatrix, just like there isxgb.slice.Booster, in order to avoid conflicts with other commonly used R frameworks.