Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test building for 32-bit arch #10021

Merged
merged 12 commits into from
Jan 31, 2024
Merged

[CI] Test building for 32-bit arch #10021

merged 12 commits into from
Jan 31, 2024

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 30, 2024

Closes #8964
Closes #10015

  • Attempt a minimal change to code base to eliminate narrowing errors from the compiler.
  • Also experiment with docker/build-push-action, which massively simplifies caching of Docker containers. It transparently uses GitHub's built-in caching feature to cache containers.
  • The 32-bit Debian container ships with latest GCC (13) which throws warning for overloaded virtual functions. For now, this warning would not be considered an error.

@hcho3 hcho3 requested a review from trivialfis January 31, 2024 10:54
src/common/hist_util.h Outdated Show resolved Hide resolved
src/common/hist_util.h Outdated Show resolved Hide resolved
hcho3 and others added 2 commits January 31, 2024 12:27
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the 32-bit build!

We will probably need to have some follow-up PRs for running some basic tests in C++, but there is no need to rush. Feel free to merge as you see fit.

@hcho3 hcho3 merged commit 4dfbe2a into dmlc:master Jan 31, 2024
25 of 28 checks passed
@hcho3 hcho3 deleted the fix_32bit branch January 31, 2024 21:20
@barracuda156
Copy link

@hcho3 Thank you very much for working on this!

@trivialfis Will this be included into the next CRAN release? (I recall I could not simply apply patches from the master onto R package code.)

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 31, 2024

Will this be included into the next CRAN release?

Probably not, since we are already having trouble uploading XGBoost 2.0 to CRAN. We are currently discussing next steps, see #9810.
In the meanwhile, you are free to build XGBoost R package from the source. (Use R CMD INSTALL . from the R-package directory.)

@barracuda156
Copy link

@hcho3 Thanks, then I can set it up manually with cloning the repo to run tests. (I need Macports environment for R stuff to work correctly.) Will update on results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32-bit arch support and WASM
3 participants