Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix JVM tests on GH Action #10064

Merged
merged 22 commits into from
Feb 22, 2024
Merged

[CI] Fix JVM tests on GH Action #10064

merged 22 commits into from
Feb 22, 2024

Conversation

trivialfis
Copy link
Member

No description provided.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 22, 2024

Need some help?

@trivialfis
Copy link
Member Author

Thank you, I'm trying to resolve the JVM build issue on Windows #10059 Not sure what's updated on GitHub, just adding some logs at the moment and see why the Python package builds fine but the JVM package doesn't.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 22, 2024

The latest Windows runner image 20240218.2.0 is somehow broken. The CI was fine for the previous version 20240211.1.0.

@trivialfis
Copy link
Member Author

Considering the Python package is working fine, it might be caused by a conflict in environment variables between the setup-java action and the new image, but I can't be sure, just making random trial and error at the moment. It seems we can't downgrade or freeze the image version https://stackoverflow.com/questions/64882287/specify-runner-version-within-github-actions

@hcho3 hcho3 changed the title [TEST] Test github action. [CI] Fix JVM tests on GH Action Feb 22, 2024
@hcho3
Copy link
Collaborator

hcho3 commented Feb 22, 2024

I was able to fix the pipeline. For some reason, you can run cmake .. -G"Visual Studio 17 2022" outside create_jni.py, but running the same command inside create_jni.py leads to an error. It looks like subprocess.run does not have access to all environment variables.

For now, we can work around the issue by building xgboost4j.dll first before running create_jni.py.

@hcho3 hcho3 merged commit eb281ff into dmlc:master Feb 22, 2024
26 of 28 checks passed
@hcho3
Copy link
Collaborator

hcho3 commented Feb 22, 2024

Merging this to unblock the CI.

@trivialfis trivialfis deleted the jvm-gh-action branch February 22, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants