Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] Refactor for learning to rank. #11012

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[dask] Refactor for learning to rank. #11012

merged 2 commits into from
Nov 22, 2024

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Nov 21, 2024 •
edited
Loading

  • Move data handling code into an independent module.
  • Move ranking tests into an independent module.
  • Use global pylint disable for import error.
  • Remove the old ranking demo.

Extracted from #11007 .

@trivialfis
[dask] Refactor for learning to rank.
c38a7e8 
- Move data handling code into an independent module.
- Move ranking tests into an independent module.
- Use global pylint disable for import error.
- Remove old ranking demo.
@trivialfis
lint.
e645ad6
@trivialfis trivialfis requested a review from hcho3 November 21, 2024 18:55
@hcho3 hcho3 closed this Nov 21, 2024
@hcho3 hcho3 reopened this Nov 21, 2024
hcho3
hcho3 reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a replacement for the ranking demo?

@trivialfis
Copy link
Member Author

@hcho3 https://github.com/dmlc/xgboost/blob/master/demo/guide-python/learning_to_rank.py .

@trivialfis trivialfis requested a review from hcho3 November 22, 2024 06:54
@trivialfis trivialfis merged commit e988b7c into dmlc:master Nov 22, 2024
55 checks passed
@trivialfis trivialfis deleted the refactor-py branch November 22, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3