Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU optimizations - part 1: extending timer to cover UpdatePredictionCache function #5107

Merged
merged 1 commit into from
Dec 9, 2019
Merged

CPU optimizations - part 1: extending timer to cover UpdatePredictionCache function #5107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/tree/updater_quantile_hist.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,14 @@ void QuantileHistMaker::Builder::Update(const GHistIndexMatrix& gmat,
bool QuantileHistMaker::Builder::UpdatePredictionCache(
const DMatrix* data,
HostDeviceVector<bst_float>* p_out_preds) {
std::vector<bst_float>& out_preds = p_out_preds->HostVector();

// p_last_fmat_ is a valid pointer as long as UpdatePredictionCache() is called in
// conjunction with Update().
if (!p_last_fmat_ || !p_last_tree_ || data != p_last_fmat_) {
return false;
}
builder_monitor_.Start("UpdatePredictionCache");

std::vector<bst_float>& out_preds = p_out_preds->HostVector();

if (leaf_value_cache_.empty()) {
leaf_value_cache_.resize(p_last_tree_->param.num_nodes,
Expand Down Expand Up @@ -385,6 +386,8 @@ bool QuantileHistMaker::Builder::UpdatePredictionCache(
}
}
}

builder_monitor_.Stop("UpdatePredictionCache");
return true;
}

Expand Down