[R] Remove stringi dependency #6109
Conversation
| } | ||
| predict(booster, newdata = pred_data) | ||
| run_booster_check(booster, name) | ||
| ## don't print C level compatibility warnings |
There was a problem hiding this comment.
Please keep the compatibility warnings. The warnings are expected.
There was a problem hiding this comment.
This is exactly why I suppressed them, because they are expected. They just pollute the test output.
There was a problem hiding this comment.
For this test case, we can add gives_warning() to ensure that this test throws a warning. I can do that in a future pull request.
There was a problem hiding this comment.
I have inhibited only C level warnings here, the R level warnings are still there and testhat still complains. So it's redundat. But ok, I have removed for now. It's for another PR indeed.
|
The train output makes it difficult to see what's going on during local development. But ok, if this is standard practice here. |
Per discussion in #5905