Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept numpy array for DMatrix slice index. #6368

Merged
merged 4 commits into from
Dec 16, 2020

Conversation

trivialfis
Copy link
Member

Close #6324 .

@trivialfis trivialfis requested a review from hcho3 December 15, 2020 18:28
@trivialfis trivialfis marked this pull request as ready for review December 15, 2020 18:33
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You should resolve the merge conflict, and we'll be good to go.

@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #6368 (37f21cf) into master (3c3f026) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6368   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files          13       13           
  Lines        3552     3552           
=======================================
  Hits         2854     2854           
  Misses        698      698           
Impacted Files Coverage Δ
python-package/xgboost/core.py 80.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3f026...37f21cf. Read the comment docs.

@trivialfis trivialfis merged commit 347f593 into dmlc:master Dec 16, 2020
@trivialfis trivialfis deleted the np-slice branch December 16, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation for python api method dmatrix::slice
3 participants