[doc] [dask] fix partitioning in Dask example #6389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6389 +/- ##
==========================================
- Coverage 79.95% 79.86% -0.09%
==========================================
Files 12 12
Lines 3477 3477
==========================================
- Hits 2780 2777 -3
- Misses 697 700 +3
Continue to review full report at Codecov.
|
|
I just updated this to the most recent |
hcho3
approved these changes
Dec 14, 2020
trivialfis
approved these changes
Dec 14, 2020
|
Let me rerun the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tonight I was testing the newest changes to
xgboost.dask(#6343 (comment)), and realized I made a mistake in #6345 !I realize I should have set the partitioning explicitly, to be sure
dataandyare partitioned the same way. This PR fixes that. Sorry for the mistake 😬I also found while doing this that
da.random.choice()puts heavy memory demands on the client, so for this example it should be switched toda.random.random()and a regression objective. I'm going to open an issue indask/daskfor theda.random.choice()issue tomorrow.