Improved InitSampling function speed by 2.12 times #6410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is connected with #6411
Discarding elements from generators takes up most of the working time in
InitSampling
.Since stdlibc++ doesn't have any random engines with o(n) complexity (little-o), we only can optimize the number of discarded elements.
std::bernoulli_distribution
requires 64-bit input, so in previous version we had to discard twice as much elements as now.This little optimization gives us ~2.12 speed up of
InitSampling
time, which translates into up to 16% speed up of the whole training time whensubsampling < 1
The quality remains the same: